netdev - Re: [net-next] Fix hardcoded interrupt name lp->name to use system device value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130927.174016.941418306620142265.davem@davemloft.net>
Date:	Fri, 27 Sep 2013 17:40:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tedheadster@...il.com
Cc:	thenaterhood@...il.com, netdev@...r.kernel.org
Subject: Re: [net-next] Fix hardcoded interrupt name lp->name to use system
 device value

From: Matthew Whitehead <tedheadster@...il.com>
Date: Sun, 22 Sep 2013 22:25:33 -0400

> On Sat, Sep 21, 2013 at 06:49:41PM +0000, Nate Levesque wrote:
>> The lance interrupt handler was using the hard-coded name which would make it difficult to tell where the interrupt came from. Changed to use the device name that made the interrupt.
>> 
>> Signed-off-by: Nate Levesque <thenaterhood@...il.com>
>> ---
>>  drivers/net/ethernet/amd/lance.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c
>> index 5c72843..256f590 100644
>> --- a/drivers/net/ethernet/amd/lance.c
>> +++ b/drivers/net/ethernet/amd/lance.c
>> @@ -754,7 +754,7 @@ lance_open(struct net_device *dev)
>>  	int i;
>>  
>>  	if (dev->irq == 0 ||
>> -		request_irq(dev->irq, lance_interrupt, 0, lp->name, dev)) {
>> +		request_irq(dev->irq, lance_interrupt, 0, dev->name, dev)) {
>>  		return -EAGAIN;
>>  	}
>>  
>> -- 
>> 1.8.1.2
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Reviewed-by: Matthew Whitehead <tedheadster@...il.com>

Applied but please use a more appriate subsystem prefix in your Subject
lines, in this case you could say "lance: " after "[net-next] "
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html