netdev - Re: [PATCH 2/2] net: phy: at803x: add suspend/resume callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5245D31C.4080104@gmail.com>
Date:	Fri, 27 Sep 2013 20:49:00 +0200
From:	Daniel Mack <zonque@...il.com>
To:	Mugunthan V N <mugunthanvnm@...com>
CC:	netdev@...r.kernel.org, davem@...emloft.net, ujhelyi.m@...il.com,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH 2/2] net: phy: at803x: add suspend/resume callbacks

On 22.09.2013 08:00, Mugunthan V N wrote:
> On Saturday 21 September 2013 08:23 PM, Daniel Mack wrote:
>> When WOL is enabled, the chip can't be put into power-down (BMCR_PDOWN)
>> mode, as that will also switch off the MAC, which consequently leads to
>> a link loss.
>>
>> Use BMCR_ISOLATE in that case, which will at least save us some
>> milliamperes in comparison to normal operation mode.
>>
>> Signed-off-by: Daniel Mack <zonque@...il.com>
> Looks good to me
> 
> Acked-by: Mugunthan V N <mugunthanvnm@...com>

Thanks :)

David, can you take these two patches with Mugunthan's Acked-by: or do
you want me to resend them?


Best regards,
Daniel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html