lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 28 Sep 2013 01:16:20 -0400
From:	Alexey Khoroshilov <>
To:	Fabio Estevam <>
CC:	Christian Lamparter <>,
	"John W. Linville" <>,,
	"" <>,
	linux-kernel <>,
Subject: Re: [PATCH] carl9170: fix leaks at failure path in carl9170_usb_probe()

On 28.09.2013 00:17, Fabio Estevam wrote:
> On Sat, Sep 28, 2013 at 12:51 AM, Alexey Khoroshilov
> <> wrote:
>> -       return request_firmware_nowait(THIS_MODULE, 1, CARL9170FW_NAME,
>> +       err = request_firmware_nowait(THIS_MODULE, 1, CARL9170FW_NAME,
>>                  &ar->udev->dev, GFP_KERNEL, ar, carl9170_usb_firmware_step2);
>> +       if (err) {
>> +               usb_put_dev(udev);
>> +               usb_put_dev(udev);
> You are doing the same free twice.
Yes, because it was get twice.
> I guess you meant to also free: usb_put_dev(ar->udev)
udev and ar->udev are equal, so technically the patch is correct.

I agree that there is some inconsistency, but I would prefer to fix it 
at usb_get_dev() side with a comment about reasons for the double get.


To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists