netdev - Re: [PATCH net-next] net ipv4: Convert ipv4.ip_local_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130928.160753.1218915059639502436.davem@davemloft.net>
Date:	Sat, 28 Sep 2013 16:07:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net ipv4: Convert ipv4.ip_local_port_range to
 be per netns

From: David Miller <davem@...emloft.net>
Date: Sat, 28 Sep 2013 15:52:28 -0400 (EDT)

> From: ebiederm@...ssion.com (Eric W. Biederman)
> Date: Sun, 22 Sep 2013 23:27:30 -0700
> 
>> 
>> - Move sysctl_local_ports from a global variable into struct netns_ipv4.
>> - Modify inet_get_local_port_range to take a struct net.
>> - Manually expand inet_get_local_range into ipv4_local_port_range
>>   because I do not know the struct net.
>> - Move the initialization of sysctl_local_ports into
>>   sysctl_net_ipv4.c:ipv4_sysctl_init_net from inet_connection_sock.c
>> 
>> Originally-by: Samya <samya@...tter.com>
>> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> 
> Applied.

I had to revert, you didn't throughly build test this.

security/selinux/hooks.c: In function ‘selinux_socket_bind’:
security/selinux/hooks.c:3933:4: error: incompatible type for argument 1 of ‘inet_get_local_port_range’
In file included from security/selinux/hooks.c:53:0:
include/net/ip.h:206:6: note: expected ‘struct net *’ but argument is of type ‘struct lsm_network_audit’

And when you repost make sure to deal with the space vs. TAB
issues pointed out to you.

Thanks.