netdev - Re: [PATCH] bgmac: add support for Byte Queue Limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1380406729.3596.7.camel@edumazet-glaptop.roam.corp.google.com>
Date:	Sat, 28 Sep 2013 15:18:49 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
Cc:	davem@...emloft.net, zajec5@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] bgmac: add support for Byte Queue Limits

On Sat, 2013-09-28 at 23:23 +0200, Hauke Mehrtens wrote:
> This makes it possible to use some more advanced queuing
> techniques with this driver.

> @@ -1198,6 +1206,8 @@ static netdev_tx_t bgmac_start_xmit(struct sk_buff *skb,
>  	struct bgmac *bgmac = netdev_priv(net_dev);
>  	struct bgmac_dma_ring *ring;
>  
> +	netdev_sent_queue(net_dev, skb->len);
> +
>  	/* No QOS support yet */
>  	ring = &bgmac->tx_ring[0];
>  	return bgmac_dma_tx_add(bgmac, ring, skb);


Well, no.

You must call netdev_sent_queue() only if packet is really queued.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html