netdev - Re: [PATCH v2] bgmac: add support for Byte Queue Limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1380410536.3596.11.camel@edumazet-glaptop.roam.corp.google.com>
Date:	Sat, 28 Sep 2013 16:22:16 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
Cc:	davem@...emloft.net, zajec5@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] bgmac: add support for Byte Queue Limits

On Sat, 2013-09-28 at 16:03 -0700, Eric Dumazet wrote:

> Unfortunately, skb->len is unsafe : hardware might already sent the
> packet and TX completion have freed it.
> 
> You must cache skb->len in a variable before allowing hardware to send
> the frame.
> 

More exactly you must call netdev_sent_queue() _before_ giving skb to
hardware, or netdev_completed_queue() might panic.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html