lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 29 Sep 2013 07:28:17 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Stephen Hemminger <stephen@...workplumber.org>,
	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] qdisc: basic classifier - remove unnecessary
 initialization

On 13-09-26 08:42 PM, Stephen Hemminger wrote:
> err is set once, then first code resets it.
>    err = tcf_exts_validate(...)
>
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
>
>
> --- a/net/sched/cls_basic.c	2013-08-10 10:36:11.657498301 -0700
> +++ b/net/sched/cls_basic.c	2013-09-05 18:05:14.718200833 -0700
> @@ -137,7 +137,7 @@ static int basic_set_parms(struct net *n
>   			   struct nlattr **tb,
>   			   struct nlattr *est)
>   {
> -	int err = -EINVAL;
> +	int err;
>   	struct tcf_exts e;
>   	struct tcf_ematch_tree t;
>


Acked-by: Jamal Hadi Salim <hadi@...atatu.com>


cheers,
jamal


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists