netdev - Re: [PATCH net-next] xen-netfront: convert to GRO API and advertise this feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380532331.1302.9.camel@kazak.uk.xensource.com>
Date:	Mon, 30 Sep 2013 10:12:11 +0100
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	David Miller <davem@...emloft.net>
CC:	<wei.liu2@...rix.com>, <netdev@...r.kernel.org>,
	<xen-devel@...ts.xen.org>, <abchak@...iper.net>
Subject: Re: [PATCH net-next] xen-netfront: convert to GRO API and advertise
 this feature

On Sat, 2013-09-28 at 15:38 -0400, David Miller wrote:
> From: Wei Liu <wei.liu2@...rix.com>
> Date: Sat, 21 Sep 2013 17:05:43 +0100
> 
> > @@ -1371,7 +1373,8 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev)
> >  	netif_napi_add(netdev, &np->napi, xennet_poll, 64);
> >  	netdev->features        = NETIF_F_IP_CSUM | NETIF_F_RXCSUM |
> >  				  NETIF_F_GSO_ROBUST;
> > -	netdev->hw_features	= NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO;
> > +	netdev->hw_features	= NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO |
> > +				  NETIF_F_GRO;
> 
> Please post a new version of this patch with the feedback you've been
> given integrated, in particular with this part removed because it is
> not necessary.
> 
> Ian, please review the patch when Wei posts it.

I will, but note:
        $ ./scripts/get_maintainer.pl -f drivers/net/xen-netfront.c 
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> (supporter:XEN HYPERVISOR IN...)
        Jeremy Fitzhardinge <jeremy@...p.org> (supporter:XEN HYPERVISOR IN...)
        xen-devel@...ts.xensource.com (moderated list:XEN HYPERVISOR IN...)
        virtualization@...ts.linux-foundation.org (open list:XEN HYPERVISOR IN...)
        netdev@...r.kernel.org (open list:NETWORKING DRIVERS)
        linux-kernel@...r.kernel.org (open list)
        
Strictly speaking I maintain netback not front, so Wei please remember
to CC the right people (mainly Konrad) as well as me.

BTW I think this separation is a good thing since it keeps changes to
the protocol "honest". Doesn't matter so much for this particular patch
since don't think it actually touches the protocol.

Ian.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html