netdev - Re: [PATCH net v3] vxlan: Use RCU apis to access sk_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130930.142334.40594744645527066.davem@davemloft.net>
Date:	Mon, 30 Sep 2013 14:23:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	stephen@...workplumber.org, jesse@...ira.com
Subject: Re: [PATCH net v3] vxlan: Use RCU apis to access sk_user_data.

From: Pravin B Shelar <pshelar@...ira.com>
Date: Tue, 24 Sep 2013 10:25:40 -0700

> Use of RCU api makes vxlan code easier to understand.  It also
> fixes bug due to missing ACCESS_ONCE() on sk_user_data dereference.
> In rare case without ACCESS_ONCE() compiler might omit vs on
> sk_user_data dereference.
> Compiler can use vs as alias for sk->sk_user_data, resulting in
> multiple sk_user_data dereference in rcu read context which
> could change.
> 
> CC: Jesse Gross <jesse@...ira.com>
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>

Applied, thanks Pravin.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html