netdev - Re: [PATCH net-next] xen-netfront: convert to GRO API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AC497311-B61D-4385-948B-2EDE3EAC37B5@juniper.net>
Date:	Tue, 1 Oct 2013 20:32:56 +0000
From:	Anirban Chakraborty <abchak@...iper.net>
To:	Ian Campbell <Ian.Campbell@...rix.com>
CC:	Wei Liu <wei.liu2@...rix.com>,
	"<netdev@...r.kernel.org>" <netdev@...r.kernel.org>,
	"<xen-devel@...ts.xen.org>" <xen-devel@...ts.xen.org>,
	"<konrad.wilk@...cle.com>" <konrad.wilk@...cle.com>
Subject: Re: [PATCH net-next] xen-netfront: convert to GRO API


On Sep 30, 2013, at 6:24 AM, Ian Campbell <Ian.Campbell@...rix.com> wrote:

> On Mon, 2013-09-30 at 13:46 +0100, Wei Liu wrote:
>> Anirban was seeing netfront received MTU size packets, which downgraded
>> throughput. The following patch makes netfront use GRO API which
>> improves throughput for that case.
>> 
>> Signed-off-by: Wei Liu <wei.liu2@...rix.com>
>> Cc: Anirban Chakraborty <abchak@...iper.net>
> 
> Acked-by: Ian Campbell <ian.campbell@...rix.com>
> 
>> Acked-by: Konrad Wilk <konrad.wilk@...cle.com>
>> ---
>> drivers/net/xen-netfront.c |    4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
>> index 36808bf..dd1011e 100644
>> --- a/drivers/net/xen-netfront.c
>> +++ b/drivers/net/xen-netfront.c
>> @@ -952,7 +952,7 @@ static int handle_incoming_queue(struct net_device *dev,
>> 		u64_stats_update_end(&stats->syncp);
>> 
>> 		/* Pass it up. */
>> -		netif_receive_skb(skb);
>> +		napi_gro_receive(&np->napi, skb);
>> 	}
>> 
>> 	return packets_dropped;
>> @@ -1051,6 +1051,8 @@ err:
>> 	if (work_done < budget) {
>> 		int more_to_do = 0;
>> 
>> +		napi_gro_flush(napi, false);
>> +
>> 		local_irq_save(flags);
>> 
>> 		RING_FINAL_CHECK_FOR_RESPONSES(&np->rx, more_to_do);
> 

We should apply it to stable as well. Thanks.
Anirban


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html