netdev - Re: [PATCH] bonding: Fix broken promiscuity reference counting issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 30 Sep 2013 22:12:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org, fubar@...ibm.com, andy@...yhouse.net,
	wudxw@...ux.vnet.ibm.com
Subject: Re: [PATCH] bonding: Fix broken promiscuity reference counting
 issue

From: Neil Horman <nhorman@...driver.com>
Date: Fri, 27 Sep 2013 12:22:15 -0400

> Recently grabbed this report:
> https://bugzilla.redhat.com/show_bug.cgi?id=1005567
> 
> Of an issue in which the bonding driver, with an attached vlan encountered the
> following errors when bond0 was taken down and back up:
> 
> dummy1: promiscuity touches roof, set promiscuity failed. promiscuity feature of
> device might be broken.
> 
> The error occurs because, during __bond_release_one, if we release our last
> slave, we take on a random mac address and issue a NETDEV_CHANGEADDR
> notification.  With an attached vlan, the vlan may see that the vlan and bond
> mac address were in sync, but no longer are.  This triggers a call to dev_uc_add
> and dev_set_rx_mode, which enables IFF_PROMISC on the bond device.  Then, when
> we complete __bond_release_one, we use the current state of the bond flags to
> determine if we should decrement the promiscuity of the releasing slave.  But
> since the bond changed promiscuity state during the release operation, we
> incorrectly decrement the slave promisc count when it wasn't in promiscuous mode
> to begin with, causing the above error
> 
> Fix is pretty simple, just cache the bonding flags at the start of the function
> and use those when determining the need to set promiscuity.
> 
> This is also needed for the ALLMULTI flag
> 
> CC: Jay Vosburgh <fubar@...ibm.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> CC: Mark Wu <wudxw@...ux.vnet.ibm.com>
> CC: "David S. Miller" <davem@...emloft.net>
> Reported-by: Mark Wu <wudxw@...ux.vnet.ibm.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html