netdev - Re: [PATCH net-next] bonding: RCUify bond_set_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130930.222709.1957983905109692683.davem@davemloft.net>
Date:	Mon, 30 Sep 2013 22:27:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	netdev@...r.kernel.org, joe.lawrence@...atus.com, fubar@...ibm.com,
	andy@...yhouse.net
Subject: Re: [PATCH net-next] bonding: RCUify bond_set_rx_mode()

From: Veaceslav Falico <vfalico@...hat.com>
Date: Sat, 28 Sep 2013 21:18:56 +0200

> Currently we rely on rtnl locking in bond_set_rx_mode(), however it's not
> always the case:
> 
> RTNL: assertion failed at drivers/net/bonding/bond_main.c (3391)
> ...
>  [<ffffffff81651ca5>] dump_stack+0x54/0x74
>  [<ffffffffa029e717>] bond_set_rx_mode+0xc7/0xd0 [bonding]
>  [<ffffffff81553af7>] __dev_set_rx_mode+0x57/0xa0
>  [<ffffffff81557ff8>] __dev_mc_add+0x58/0x70
>  [<ffffffff81558020>] dev_mc_add+0x10/0x20
>  [<ffffffff8161e26e>] igmp6_group_added+0x18e/0x1d0
>  [<ffffffff81186f76>] ? kmem_cache_alloc_trace+0x236/0x260
>  [<ffffffff8161f80f>] ipv6_dev_mc_inc+0x29f/0x320
>  [<ffffffff8161f9e7>] ipv6_sock_mc_join+0x157/0x260
> ...
> 
> Fix this by using RCU primitives.
> 
> Reported-by: Joe Lawrence <joe.lawrence@...atus.com>
> Tested-by: Joe Lawrence <joe.lawrence@...atus.com>
> CC: Jay Vosburgh <fubar@...ibm.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html