lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Oct 2013 10:44:32 -0700 From: "Luis R. Rodriguez" <mcgrof@...not-panic.com> To: Joe Perches <joe@...ches.com>, Julia Lawall <julia.lawall@...6.fr> Cc: Kalle Valo <kvalo@....qualcomm.com>, netdev <netdev@...r.kernel.org>, ath10k@...ts.infradead.org Subject: Re: [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN On Tue, Oct 1, 2013 at 11:40 PM, Joe Perches <joe@...ches.com> wrote: > Please include netdev. (cc'd) > >> Joe Perches <joe@...ches.com> writes: >> >> > Convert the memset/memcpy uses of 6 to ETH_ALEN >> > where appropriate. > >> > Signed-off-by: Joe Perches <joe@...ches.com> I think these sorts of patches are good -- but once applied it'd be good if we can get the SmPL grammar expressed for it and then have developers / maintainers regularly doing: make coccicheck MODE=patch M=path > path-cocci.patch Unfortunately right now MODE=patch takes about 3 1/2 minutes for ath9k, MODE=org takes ~10 minutes for ath9k (17 minutes for all of ath/), and MODE=context takes ~8 minutes on ath9k -- I do believe its a bit unreasonable to expect patch submitters to use this, but certainly great practice. Some of the time differences on the reports can be explained by the fact that some SmPL will only be used for some modes. Even though it takes a while right now it'd be great practice to use coccicheck to prevent these type of changes from going in again, things that checkpatch.pl won't be able to catch. Luis -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists