netdev - Re: [PATCH V3 net-next] fib_trie: avoid a redundant bit judgement in inflate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131002.163751.1094931323876276388.davem@davemloft.net>
Date:	Wed, 02 Oct 2013 16:37:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	baker.kernel@...il.com
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 net-next] fib_trie: avoid a redundant bit judgement
 in inflate

From: baker.kernel@...il.com
Date: Tue,  1 Oct 2013 07:45:09 +0800

> From: "baker.zhang" <baker.kernel@...il.com>
> 
> Because 'node' is the i'st child of 'oldnode',
> thus, here 'i' equals
> tkey_extract_bits(node->key, oldtnode->pos, oldtnode->bits)
> 
> we just get 1 more bit,
> and need not care the detail value of this bits.
> 
> I apologize for the mistake.
> 
> I generated the patch on a branch version,
> and did not notice the put_child has been changed.
> 
> I have redone the test on HEAD version with my patch.

Applied, thanks for testing things so thoroughly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html