lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 02 Oct 2013 03:41:28 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Jiri Pirko <jiri@...nulli.us> Cc: netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org, davem@...emloft.net, kuznet@....inr.ac.ru, jmorris@...ei.org, kaber@...sh.net, herbert@...dor.apana.org.au Subject: Re: [PATCH] ipv6: udp packets following an UFO enqueued packet need also be handled by UFO On Wed, 2013-10-02 at 10:58 +0200, Jiri Pirko wrote: > Wed, Oct 02, 2013 at 01:25:34AM CEST, hannes@...essinduktion.org wrote: > >- if (((length > mtu) || (skb && skb_is_gso(skb))) && > >+ if (((length > mtu) || (skb && skb_has_frags(skb))) && > > This seems correct to me. sk_is_gso would work as well is you apply my > patch "[patch net] ip6_output: do skb ufo init for peeked non ufo skb as > well" which does the setting of gso_size. Well, skb having frags or not should not be a concern : Thats an allocation choice (lets say to avoid high order allocations). Setting gso_size is probably better. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists