netdev - Re: [PATCH net-next] tcp/dccp: remove twchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380837491.19002.240.camel@edumazet-glaptop.roam.corp.google.com>
Date:	Thu, 03 Oct 2013 14:58:11 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp/dccp: remove twchain

On Thu, 2013-10-03 at 17:51 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Thu, 03 Oct 2013 00:22:02 -0700
> 
> > Current inet_ehash_bucket contains two chains, one for ESTABLISH (and
> > friend states) sockets, another for TIME_WAIT sockets only.
> > 
> > As the hash table is sized to get at most one socket per bucket, it
> > makes little sense to have separate twchain, as it makes the lookup
> > slightly more complicated, and doubles hash table memory usage.
> 
> The idea was that long standing time-wait sockets should be forced to
> provably never appear in same hash chains and thus cause interference
> with lookups on established sockets.
> 
> On the other hand, moving sockets between these two tables has a
> non-trivial cost, and synchronization complexity.
> 
> So perhaps your change gives the right tradeoff.
> 
> Eric this patch needs to be respun against current net-next
> in order for it to apply cleanly, please do that and I'll add
> it.

I think the main problem comes from this commit in net tree ?

commit 80ad1d61e72d626e30ebe8529a0455e660ca4693
Author: Eric Dumazet <edumazet@...gle.com>
Date:   Tue Oct 1 21:04:11 2013 -0700

    net: do not call sock_put() on TIMEWAIT sockets
    
    commit 3ab5aee7fe84 ("net: Convert TCP & DCCP hash tables to use RCU /
    hlist_nulls") incorrectly used sock_put() on TIMEWAIT sockets.
    
    We should instead use inet_twsk_put()

I think you could safely ignore the warnings
because of (tcp: shrink tcp6_timewait_sock by one cache line) latest changes

patching file include/net/inet_timewait_sock.h
Hunk #1 succeeded at 141 (offset 5 lines).
Hunk #2 succeeded at 180 (offset 5 lines).

Please tell me if I need to resend, thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html