lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 02 Oct 2013 21:18:44 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Joe Perches <joe@...ches.com> Cc: Kalle Valo <kvalo@....qualcomm.com>, Julia Lawall <julia.lawall@...6.fr>, "Luis R. Rodriguez" <mcgrof@...not-panic.com>, netdev <netdev@...r.kernel.org>, ath10k@...ts.infradead.org, "John W. Linville" <linville@...driver.com> Subject: Re: [PATCH net-next] ath10k: wmi: Convert use of 6 to ETH_ALEN On Wed, 2013-10-02 at 20:39 -0700, Joe Perches wrote: > Use the appropriate define instead of 6. > > Signed-off-by: Joe Perches <joe@...ches.com> > Noticed-by: Julia Lawall <julia.lawall@...6.fr> via spatch script > > --- > > drivers/net/wireless/ath/ath10k/wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c > index bee88e8..48d44e7 100644 > --- a/drivers/net/wireless/ath/ath10k/wmi.c > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > @@ -1758,7 +1758,7 @@ int ath10k_wmi_vdev_up(struct ath10k *ar, u32 vdev_id, u32 aid, const u8 *bssid) > cmd = (struct wmi_vdev_up_cmd *)skb->data; > cmd->vdev_id = __cpu_to_le32(vdev_id); > cmd->vdev_assoc_id = __cpu_to_le32(aid); > - memcpy(&cmd->vdev_bssid.addr, bssid, 6); > + memcpy(&cmd->vdev_bssid.addr, bssid, ETH_ALEN); > > ath10k_dbg(ATH10K_DBG_WMI, > "wmi mgmt vdev up id 0x%x assoc id %d bssid %pM\n", I don't get it. Why leaving this then ? struct wmi_mac_addr { union { u8 addr[6]; struct { u32 word0; u32 word1; } __packed; } __packed; } __packed; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists