lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 03 Oct 2013 16:00:49 -0400 (EDT) From: David Miller <davem@...emloft.net> To: hns@...delico.com Cc: j.dumon@...ion.com, marek.belisko@...il.com, linux-usb@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication From: "Dr. H. Nikolaus Schaller" <hns@...delico.com> Date: Thu, 3 Oct 2013 21:40:34 +0200 > I have made the bug observation from debug log that this bit is set in a response > each time the modem has a RING message. It might be specific to this modem > and firmware version, i.e. a firmware bug. But we have no means to verify or even > change it in the firmware. > > I.e. the driver must handle it in a better way. > > Because the notification is rejected by the driver, the driver will hang up and the > whole modem connection breaks down. > > With this patch, the problem was never observed again in ~2 years. > > I'd hope the maintainer of this driver can shed some light on it. I think if you suspect the bit is set in response to RING messages then you should define a macro so that the number is not just magic, and put a descriptrive comment above the macro definition for that bit. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists