| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1380830685.3419.13.camel@bwh-desktop.uk.level5networks.com> Date: Thu, 3 Oct 2013 21:04:45 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next] tcp/dccp: remove twchain On Thu, 2013-10-03 at 00:22 -0700, Eric Dumazet wrote: [...] > @@ -146,26 +150,21 @@ void __inet_twsk_hashdance(struct inet_timewait_sock *tw, struct sock *sk, > spin_lock(lock); > > /* > - * Step 2: Hash TW into TIMEWAIT chain. > - * Should be done before removing sk from established chain > - * because readers are lockless and search established first. > + * Step 2: Hash TW into tcp ehash chain. > + * Notes : > + * - tw_refcnt is set to 3 because : > + * - We have one reference from bhash chain. > + * - We have one reference from ehash chain. > + * We can use atomic_set() because prior spin_lock()/spin_unlock() > + * committed into memory all tw fields. > */ > - inet_twsk_add_node_rcu(tw, &ehead->twchain); > + atomic_set(&tw->tw_refcnt, 1 + 1 + 1); > + inet_twsk_add_node_rcu(tw, &ehead->chain); [...] 'will commit' rather than 'committed'? But isn't this also a separate optimisation? Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists