| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20131003.170126.2297161431158026731.davem@davemloft.net> Date: Thu, 03 Oct 2013 17:01:26 -0400 (EDT) From: David Miller <davem@...emloft.net> To: andrea.merello@...il.com Cc: jie.yang@...eros.com, xiong.huang@...eros.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] atl1e: enable support for NETIF_F_RXALL and NETIF_F_RXCRC features From: Andrea Merello <andrea.merello@...il.com> Date: Thu, 3 Oct 2013 21:18:37 +0200 > This patch allows (optionally, via ethtool) the atl1e NIC to: > - Receive bad frames (runt, bad-fcs, etc..) > - Receive full frames without stripping the FCS. > > This has been tested on my board by injecting runt and bad-fcs > frames with a FPGA-based device. > > The particular scenario of receiving very short frames (<4 bytes) > without passing FCS to the upper layer has been also tested: > This could be potentially dangerous because the driver performs a > 4 byte subtraction on the frame length, but I finally have NOT > added anything to avoid this because it seems the NIC always > discards frames so much short.. > If someone still have some reason to worry about this, please > tell me.. I will add an explicit SW check.. > > Signed-off-by: Andrea Merello <andrea.merello@...il.com> Looks good, applied, thanks Andrea. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists