netdev - Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380836781.3419.17.camel@bwh-desktop.uk.level5networks.com>
Date:	Thu, 3 Oct 2013 22:46:21 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jon Mason <jon.mason@...el.com>
CC:	Alexander Gordeev <agordeev@...hat.com>,
	<linux-kernel@...r.kernel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Michael Ellerman <michael@...erman.id.au>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	"Ingo Molnar" <mingo@...hat.com>, Tejun Heo <tj@...nel.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Andy King <acking@...are.com>,
	Matt Porter <mporter@...nel.crashing.org>,
	<stable@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-mips@...ux-mips.org>, <linuxppc-dev@...ts.ozlabs.org>,
	<linux390@...ibm.com>, <linux-s390@...r.kernel.org>,
	<x86@...nel.org>, <linux-ide@...r.kernel.org>,
	<iss_storagedev@...com>, <linux-nvme@...ts.infradead.org>,
	<linux-rdma@...r.kernel.org>, <netdev@...r.kernel.org>,
	<e1000-devel@...ts.sourceforge.net>, <linux-driver@...gic.com>,
	"Solarflare linux maintainers" <linux-net-drivers@...arflare.com>,
	"VMware, Inc." <pv-drivers@...are.com>,
	<linux-scsi@...r.kernel.org>
Subject: Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when
 populate_msi_sysfs() failed

On Wed, 2013-10-02 at 17:39 -0700, Jon Mason wrote:
> On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote:
> > Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> 
> Since you are changing the behavior of the msix_capability_init
> function on populate_msi_sysfs error, a comment describing why in this
> commit would be nice.
[...]

This function was already treating that error as fatal, and freeing the
MSIs.  The change in behaviour is that it now returns the error code in
this case, rather than 0.  This is obviously correct and properly
described by the one-line summary.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html