netdev - Re: [PATCH net-next v2 3/3] net: ipv4 only populate IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1380921610.3564.43.camel@edumazet-glaptop.roam.corp.google.com>
Date:	Fri, 04 Oct 2013 14:20:10 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Shawn Bohrer <shawn.bohrer@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, tomk@...advisors.com,
	Shawn Bohrer <sbohrer@...advisors.com>
Subject: Re: [PATCH net-next v2 3/3] net: ipv4 only populate IP_PKTINFO when
 needed

On Fri, 2013-10-04 at 14:28 -0500, Shawn Bohrer wrote:
> From: Shawn Bohrer <sbohrer@...advisors.com>
> 
> The since the removal of the routing cache computing
> fib_compute_spec_dst() does a fib_table lookup for each UDP multicast
> packet received.  This has introduced a performance regression for some
> UDP workloads.
> 
> This change skips populating the packet info for sockets that do not have
> IP_PKTINFO set.
> 
> Benchmark results from a netperf UDP_RR test:
> Before 89789.68 transactions/s
> After  90587.62 transactions/s
> 
> Benchmark results from a fio 1 byte UDP multicast pingpong test
> (Multicast one way unicast response):
> Before 12.63us RTT
> After  12.48us RTT
> 
> Signed-off-by: Shawn Bohrer <sbohrer@...advisors.com>
> ---
> v2 changes:
> 
> * ipv4_pktinfo_prepare() now takes a const struct sock*


Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html