netdev - Re: [PATCH] net: secure_seq: Move net_secret_init() definition into CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131005.162752.155685316245760253.davem@davemloft.net>
Date:	Sat, 05 Oct 2013 16:27:52 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	edumazet@...gle.com, hannes@...ressinduktion.org,
	netdev@...r.kernel.org, olof@...om.net, fabio.estevam@...escale.com
Subject: Re: [PATCH] net: secure_seq: Move net_secret_init() definition
 into CONFIG_IPV6 if block

From: Fabio Estevam <festevam@...il.com>
Date: Sat,  5 Oct 2013 17:09:50 -0300

> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> Commit 9a3bab6b05 (net: net_secret should not depend on TCP) introduced
> the following build warning when CONFIG_IPV6 is not selected:
> 
> net/core/secure_seq.c:17:13: warning: 'net_secret_init' defined but not used [-Wunused-function]
> 
> Fix it by moving net_secret_init(void) inside the '#if IS_ENABLED(CONFIG_IPV6)'
> block.
> 
> Reported-by: Olof Johansson <olof@...om.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

seq_scale is used by secure_tcp_sequence_number, which is only protected
by CONFIG_INET.  I have no idea how you can get this build problem.

And I cannot reproduce it here:

[davem@drr net]$ egrep CONFIG_IPV6 .config
# CONFIG_IPV6 is not set
[davem@drr net]$ make net/core/secure_seq.o
scripts/kconfig/conf --silentoldconfig Kconfig
make[1]: Nothing to be done for `all'.
make[1]: Nothing to be done for `relocs'.
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CALL    scripts/checksyscalls.sh
  CC      net/core/secure_seq.o
[davem@drr net]$ 

Furthermore your commit message is talking about net_secret_init but
your patch does things with seq_scale.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html