netdev - Re: [PATCH] can: dev: fix nlmsg size calculation in can_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <705c23ba0332d9658b8760cd5d460e8a@grandegger.com>
Date:	Mon, 07 Oct 2013 16:24:28 +0200
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	<netdev@...r.kernel.org>, <linux-can@...r.kernel.org>,
	<kernel@...gutronix.de>
Subject: Re: [PATCH] can: dev: fix nlmsg size calculation in  can_get_size()

On Mon, 07 Oct 2013 16:14:36 +0200, Marc Kleine-Budde <mkl@...gutronix.de>
wrote:
> On 10/05/2013 10:50 PM, Wolfgang Grandegger wrote:
>> On 10/05/2013 09:25 PM, Marc Kleine-Budde wrote:
>>> This patch fixes the calculation of the nlmsg size, by adding the
>>> missing
>>> nla_total_size().
>>>
>>> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
>>> ---
>>> Hello,
>>>
>>> this patch touches the rtnl_link_ops get_size() callback:
>>>
>>>     static struct rtnl_link_ops can_link_ops __read_mostly = {
>>>     ...
>>>     	.get_size	= can_get_size,
>>>     ...
>>>     };
>>>
>>> By looking at other nlmsg size calculation I think a nla_total_size()
>>> for all
>>> contributers is needed. Am I correct?
>> 
>> Yes, seems so, nla_put() calls this code:
>> 
>>   http://lxr.free-electrons.com/source/lib/nlattr.c#L328
> 
> Is this an Acked-by? :)

Yep, obviously a long time ago that I did something for Linux-CAN :(.

Wolfgang.

> 
> Marc
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html