netdev - Re: [PATCH net-next] bonding: ensure that TLB mode's active slave has correct mac filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131008.160710.1450763820344380912.davem@davemloft.net>
Date:	Tue, 08 Oct 2013 16:07:10 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	netdev@...r.kernel.org, fubar@...ibm.com, andy@...yhouse.net,
	yuvalmin@...adcom.com
Subject: Re: [PATCH net-next] bonding: ensure that TLB mode's active slave
 has correct mac filter

From: Veaceslav Falico <vfalico@...hat.com>
Date: Mon,  7 Oct 2013 09:17:20 +0200

> Currently, in TLB mode we change mac addresses only by memcpy-ing the to
> net_device->dev_addr, without actually setting them via
> dev_set_mac_address(). This permits us to receive all the traffic always on
> one mac address.
> 
> However, in case the interface flips, some drivers might enforce the
> mac filtering for its FW/HW based on current ->dev_addr, and thus we won't
> be able to receive traffic on that interface, in case it will be selected
> as active in TLB mode.
> 
> Fix it by setting the mac address forcefully on every new active slave that
> we select in TLB mode.
> 
> CC: Jay Vosburgh <fubar@...ibm.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> CC: Yuval Mintz <yuvalmin@...adcom.com>
> Reported-by: Yuval Mintz <yuvalmin@...adcom.com>
> Tested-by: Yuval Mintz <yuvalmin@...adcom.com>
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>

Since we hole the RTNL during this tricky operation I guess this is fine.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html