netdev - Re: [PATCH] pkt_sched: fq: fix non TCP flows pacing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131008.165318.1392122841162708841.davem@davemloft.net>
Date:	Tue, 08 Oct 2013 16:53:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, sesse@...gle.com
Subject: Re: [PATCH] pkt_sched: fq: fix non TCP flows pacing

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 07 Oct 2013 14:44:29 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Steinar reported FQ pacing was not working for UDP flows.
> 
> It looks like the initial sk->sk_pacing_rate value of 0 was
> a wrong choice. We should init it to ~0U like sk_max_pacing_rate
> 
> Then, TCA_FQ_FLOW_DEFAULT_RATE should be removed because it makes
> no real sense. (The default rate is really : ~0U)
> 
> While debugging this issue, I realized sk_pacing_rate is shared between
> transport and packet scheduler without locking / barriers :
> 
> We should use ACCESS_ONCE() to make sure compiler wont perform
> multiple loads or stores.
> 
> Reported-by: Steinar H. Gunderson <sesse@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Is this meant for net or net-next?  It doesn't apply cleanly to the
former.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html