netdev - Re: [PATCH net-next 2/2] ipv6: make lookups simpler and faster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131008.232125.1605815898898029345.davem@davemloft.net>
Date:	Tue, 08 Oct 2013 23:21:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] ipv6: make lookups simpler and faster

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 03 Oct 2013 15:42:29 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> TCP listener refactoring, part 4 :
> 
> To speed up inet lookups, we moved IPv4 addresses from inet to struct
> sock_common
> 
> Now is time to do the same for IPv6, because it permits us to have fast
> lookups for all kind of sockets, including upcoming SYN_RECV.
> 
> Getting IPv6 addresses in TCP lookups currently requires two extra cache
> lines, plus a dereference (and memory stall).
> 
> inet6_sk(sk) does the dereference of inet_sk(__sk)->pinet6
> 
> This patch is way bigger than its IPv4 counter part, because for IPv4,
> we could add aliases (inet_daddr, inet_rcv_saddr), while on IPv6,
> it's not doable easily.
> 
> inet6_sk(sk)->daddr becomes sk->sk_v6_daddr
> inet6_sk(sk)->rcv_saddr becomes sk->sk_v6_rcv_saddr
> 
> And timewait socket also have tw->tw_v6_daddr & tw->tw_v6_rcv_saddr
> at the same offset.
> 
> We get rid of INET6_TW_MATCH() as INET6_MATCH() is now the generic
> macro.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks a lot Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html