netdev - Re: [PATCH] net: af802154: Fix wrong structure declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 10 Oct 2013 03:36:07 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	David Miller <davem@...emloft.net>
Cc:	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	netdev@...r.kernel.org, linux-zigbee-devel@...ts.sourceforge.net
Subject: Re: [PATCH] net: af802154: Fix wrong structure declaration

On Tue, Oct 08, 2013 at 03:49:10PM -0400, David Miller wrote:
> From: Guenter Roeck <linux@...ck-us.net>
> Date: Sun,  6 Oct 2013 14:44:01 -0700
> 
> > net_devce doesn't exist.
> > 
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> 
> This is simply rediculous.
> 
Problem with this kind of patch is that every possible remedy could
trigger a "this is ridiculous" response, including the one you propose
(as in "this is ridiculous - it increases compile time with no real
benefit").

The only safe patch is no patch, which I think is the real takeaway.

Guenter

> The reason I say this is that every user of this header includes
> net/sock.h which in turn includes linux/skbuff.h and linux/netdevice.h
> which therefore bring in all the necessary structure definitions.
> 
> Really, the most correct change is to make af802154.h explicitly
> include those header files.
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html