lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 10 Oct 2013 18:29:45 +0300
From:	Eli Cohen <>
To:	Alexander Gordeev <>
Cc:, Bjorn Helgaas <>,
	Ralf Baechle <>,
	Michael Ellerman <>,
	Benjamin Herrenschmidt <>,
	Martin Schwidefsky <>,
	Ingo Molnar <>, Tejun Heo <>,
	Dan Williams <>,
	Andy King <>, Jon Mason <>,
	Matt Porter <>,,,,,,,,,,,,,,
	Solarflare linux maintainers <>,
	"VMware, Inc." <>,
Subject: Re: [PATCH RFC 50/77] mlx5: Update MSI/MSI-X interrupts enablement

On Thu, Oct 03, 2013 at 09:48:39PM +0200, Alexander Gordeev wrote:
> pci_enable_msix() may fail, but it can not return a positive number.

That is true according to the current logic but the comment on top of
pci_enable_msix() still says:
"A return of < 0 indicates a failure.  Or a return of > 0 indicates
that driver request is exceeding the number of irqs or MSI-X vectors

So you're counting on an implementation that may change in the future.
I think leaving the code as it is now is safer.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists