netdev - Re: [PATCH net-next v2 1/9] qlcnic: Print informational messages only once during driver load.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1381520000.27498.21.camel@joe-AO722>
Date:	Fri, 11 Oct 2013 12:33:20 -0700
From:	Joe Perches <joe@...ches.com>
To:	Himanshu Madhani <himanshu.madhani@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Dept_NX_Linux_NIC_Driver@...gic.com,
	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
Subject: Re: [PATCH net-next v2 1/9] qlcnic: Print informational messages
 only once during driver load.

On Fri, 2013-10-11 at 14:42 -0400, Himanshu Madhani wrote:
> From: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>

trivia:

> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
[]
> @@ -94,13 +94,30 @@ qlcnic_83xx_config_vnic_buff_descriptors(struct qlcnic_adapter *adapter)
[]
> +		for (i = 0; i < ahw->act_pci_func; i++, npar++) {
> +			dev_info(dev, "id = %d active = %d type = %d\n"
> +				 "\tport = %d min bw = %d max bw = %d\n"
> +				 "\tmac_addr =  %pM\n", npar->pci_func,
> +				 npar->active, npar->type, npar->phy_port,
> +				 npar->min_bw, npar->max_bw, npar->mac);

Only the first line in dmesg will be prefixed with device
information this way.  This can make it difficult to use
"$ grep qlcnic" dmesg easily.  It might be better to use
3 lines or just 1 line.

			dev_info(dev, "id = %d active = %d type = %d port = %d min bw = %d max bw = %d mac_addr = %pM\n",
				 npar->pci_func, npar->active, npar->type,
				 npar->phy_port, npar->min_bw, npar->max_bw,
				 npar->mac);

I'd've used colons to shorten it a bit too:

			dev_info(dev, "id:%d active:%d type:%d port:%d min_bw:%d max_bw:%d mac_addr:%pM\n",
				 npar->pci_func, npar->active, npar->type,
				 npar->phy_port, npar->min_bw, npar->max_bw,
				 npar->mac);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html