netdev - Re: [PATCH] l2tp: must disable bh before calling l2tp_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131011.172021.827876891266213757.davem@davemloft.net>
Date:	Fri, 11 Oct 2013 17:20:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	f.cachereul@...halink.fr, jchapman@...alix.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] l2tp: must disable bh before calling l2tp_xmit_skb()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 10 Oct 2013 06:30:09 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> François Cachereul made a very nice bug report and suspected
> the bh_lock_sock() / bh_unlok_sock() pair used in l2tp_xmit_skb() from
> process context was not good.
> 
> This problem was added by commit
> ("l2tp: Fix locking in l2tp_core.c").

I added the commit SHA ID for you, please take care of this next time.

> l2tp_eth_dev_xmit() runs from BH context, so we must disable BH
> from other l2tp_xmit_skb() users.
 ...
> Reported-by: François Cachereul <f.cachereul@...halink.fr>
> Tested-by: François Cachereul <f.cachereul@...halink.fr>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html