netdev - Re: [Bridge] [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131012174354.GE20321@order.stressinduktion.org>
Date:	Sat, 12 Oct 2013 19:43:54 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Josh Triplett <josh@...htriplett.org>, peterz@...radead.org,
	fweisbec@...il.com, dhowells@...hat.com, edumazet@...gle.com,
	gaofeng@...fujitsu.com, mingo@...nel.org,
	bridge@...ts.linux-foundation.org, jmorris@...ei.org,
	dipankar@...ibm.com, darren@...art.com, rostedt@...dmis.org,
	niv@...ibm.com, mathieu.desnoyers@...icios.com,
	kuznet@....inr.ac.ru, tglx@...utronix.de,
	johannes@...solutions.net, laijs@...fujitsu.com,
	yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
	linux-decnet-user@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kaber@...sh.net,
	stephen@...workplumber.org, sbw@....edu, tgraf@...g.ch,
	akpm@...ux-foundation.org, fengguang.wu@...el.com,
	davem@...emloft.net
Subject: Re: [Bridge] [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13

On Sat, Oct 12, 2013 at 07:39:30PM +0200, Hannes Frederic Sowa wrote:
> On Sat, Oct 12, 2013 at 10:13:45AM -0700, Paul E. McKenney wrote:
> > On Fri, Oct 11, 2013 at 11:53:27PM -0700, Josh Triplett wrote:
> > > On Fri, Oct 11, 2013 at 04:16:59PM -0700, Paul E. McKenney wrote:
> > > > Changes from v2:
> > > > 
> > > > o	Switch from rcu_assign_pointer() to ACCESS_ONCE() given that
> > > > 	the pointers are all --rcu and already visible to readers,
> > > > 	as suggested by Eric Dumazet and Josh Triplett.
> > > 
> > > Hang on a moment.  Do *none* of these cases need write memory barriers?
> > 
> > Sigh.  Some afternoons it doesn't pay to touch the keyboard.
> > 
> > Thank you for catching this.  I will fix, but at this point, I am thinking
> > in terms of 3.14 rather than 3.13 for this series.
> 
> Some of them looked safe. You could also replace --rcu with __rcu in the
> comments while at it.

Most of them deal with management, maybe a rtnl_assign_pointer with lockdep
check for rtnl lock could help to not clean up the wrong bits.

I don't know if rtnl_assign_pointer is that a could name as it does not really
explain why the barrier is not needed there. :/

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html