netdev - Re: [PATCH] staging: octeon-ethernet: trivial: Avoid OOPS if phydev is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131014101051.GH6192@mwanda>
Date:	Mon, 14 Oct 2013 13:10:51 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Sebastian Pöhn <sebastian.poehn@...il.com>,
	support@...iumnetworks.com, netdev@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org
Subject: Re: [PATCH] staging: octeon-ethernet: trivial: Avoid OOPS if phydev
 is not set

On Sun, Oct 13, 2013 at 02:28:10PM -0700, Greg KH wrote:
> On Sun, Oct 13, 2013 at 08:59:54PM +0200, Sebastian Pöhn wrote:
> > A zero pointer deref on priv->phydev->link was causing oops on our systems.
> > Might be related to improper configuration but we should fail gracefully here ;-)
> > 
> > Signed-off-by: Sebastian Poehn <sebastian.poehn@...glemail.com>
> > 
> > ---
> > 
> > diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
> > index 83b1030..bc8c503 100644
> > --- a/drivers/staging/octeon/ethernet-mdio.c
> > +++ b/drivers/staging/octeon/ethernet-mdio.c
> > @@ -121,6 +121,9 @@ static void cvm_oct_adjust_link(struct net_device *dev)
> >         struct octeon_ethernet *priv = netdev_priv(dev);
> >         cvmx_helper_link_info_t link_info;
> >  
> > +       if(!priv->phydev)
> > +               return ;
> 
> Please always run your patches through the scripts/checkpatch.pl tool so
> that maintainers don't have to point out the obvious coding syle errors
> by hand each time :)

Also it's whitespace damaged and doesn't apply.

> 
> Care to try again?
> 
> Also, how was phydev NULL?  What was causing that?

To me it looks like phydev is always NULL.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html