netdev - Re: [PATCH] net/ethernet: cpsw: Bugfix interrupts before enabling napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8738o4rs36.fsf@dell.be.48ers.dk>
Date:	Mon, 14 Oct 2013 13:48:29 +0200
From:	Peter Korsgaard <peter@...sgaard.com>
To:	Markus Pargmann <mpa@...gutronix.de>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <florian@...nwrt.org>,
	Mugunthan V N <mugunthanvnm@...com>,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH] net/ethernet: cpsw: Bugfix interrupts before enabling napi

>>>>> "Markus" == Markus Pargmann <mpa@...gutronix.de> writes:

 Markus> If interrupts happen before napi_enable was called, the driver will not
 Markus> work as expected. Network transmissions are impossible in this state.
 Markus> This bug can be reproduced easily by restarting the network interface in
 Markus> a loop. After some time any network transmissions on the network
 Markus> interface will fail.

 Markus> This patch fixes the bug by enabling napi before enabling the network
 Markus> interface interrupts.

 Markus> Signed-off-by: Markus Pargmann <mpa@...gutronix.de>

Acked-by: Peter Korsgaard <jacmet@...site.dk>

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html