netdev - Re: [ovs-dev] [PATCH v2 net-next] openvswitch: fix vport-netdev unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 Oct 2013 20:23:03 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	dev@...nvswitch.org, netdev@...r.kernel.org
Subject: Re: [ovs-dev] [PATCH v2 net-next] openvswitch: fix vport-netdev unregister

On Sun, Oct 13, 2013 at 2:22 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Sat, 12 Oct 2013 at 01:12 GMT, Alexei Starovoitov <ast@...mgrid.com> wrote:
>> @@ -87,7 +81,11 @@ static int dp_device_event(struct notifier_block *unused, unsigned long event,
>>       if (!vport)
>>               return NOTIFY_DONE;
>>
>> -     if (event == NETDEV_UNREGISTER) {
>> +     if (event == NETDEV_UNREGISTER && dev->priv_flags & IFF_OVS_DATAPATH) {
>> +             /* upper_dev_unlink and decrement promisc immediately */
>> +             ovs_netdev_detach_dev(vport);
>> +
>> +             /* schedule vport destroy, dev_put and genl notification */
>
> ovs_netdev_get_vport() already checks IFF_OVS_DATAPATH flag before this 'if'.

:) good point. will do v3.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html