netdev - Re: [RFC PATCH v2 1/1] Workqueue based vhost workers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131014112725.34d211aa@nehalam.linuxnetplumber.net>
Date:	Mon, 14 Oct 2013 11:27:25 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Bandan Das <bsd@...hat.com>
Cc:	kvm@...r.kernel.org, netdev@...r.kernel.org,
	Michael Tsirkin <mst@...hat.com>,
	Jason Wang <jasowang@...hat.com>, Bandan Das <bsd@...efile.in>
Subject: Re: [RFC PATCH v2 1/1] Workqueue based vhost workers

On Sun, 13 Oct 2013 21:55:43 -0400
Bandan Das <bsd@...hat.com> wrote:

> +
> +	if (cmwq_worker) {
> +		ret = vhost_wq_init();
> +		if (ret) {
> +			pr_info("Enabling wq based vhost workers failed! "
> +				 "Switching to device based worker instead\n");
> +			cmwq_worker = 0;
> +		} else
> +		  pr_info("Enabled workqueues based vhost workers\n");
> +	}

Why keep two mechanisms (and two potential code paths to maintain)
when the only way vhost_wq_init() can fail is if out of memory.
You may have needed the messages and this during development but for
the final version just do it one way.

If alloc_workqueue fails, then the net_init function should propogate
the error code and fail as well.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html