netdev - Re: [PATCHv2] staging: octeon-ethernet: trivial: Avoid OOPS if phydev is not set

Open Source and information security mailing list archives

Message-ID: <20131014190610.GC4260@blackmetal.musicnaut.iki.fi>
Date:	Mon, 14 Oct 2013 22:06:10 +0300
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Sebastian Pöhn <sebastian.poehn@...il.com>
Cc:	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	dan.carpenter@...cle.com
Subject: Re: [PATCHv2] staging: octeon-ethernet: trivial: Avoid OOPS if
 phydev is not set

On Mon, Oct 14, 2013 at 07:58:55PM +0200, Sebastian Pöhn wrote:
> Sorry. Haven't signed off for a while now :(
> 
> I bet that this is really an issue of incorrect OF information. If I find out more I'll let you know.
> 
> @dan: The code works for some interfaces - so phydev is set correctly in some cases.

Kernel git log is not a chat forum; please write a proper changelog,
if possible include the original oops log.

Thanks,

A.

> Signed-off-by: Sebastian Poehn <sebastian.poehn@...glemail.com>
> ---
> diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
> index 83b1030..bc8c503 100644
> --- a/drivers/staging/octeon/ethernet-mdio.c
> +++ b/drivers/staging/octeon/ethernet-mdio.c
> @@ -121,6 +121,9 @@ static void cvm_oct_adjust_link(struct net_device *dev)
>  	struct octeon_ethernet *priv = netdev_priv(dev);
>  	cvmx_helper_link_info_t link_info;
>  
> +	if (!priv->phydev)
> +		return;
> +
>  	if (priv->last_link != priv->phydev->link) {
>  		priv->last_link = priv->phydev->link;
>  		link_info.u64 = 0;
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives