netdev - Re: [PATCH] drivers: net: phy: marvell.c: removed checkpatch.pl warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Oct 2013 21:12:40 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Avinash kumar <avi.kp.137@...il.com>
CC:	davem@...emloft.net, michal.simek@...inx.com, lars@...afoo.de,
	RHoover@...ilentinc.com, netdev@...r.kernel.org
Subject: Re: [PATCH] drivers: net: phy: marvell.c: removed checkpatch.pl warnings

Hello.

On 09/30/2013 08:06 AM, Avinash kumar wrote:

> removes following warnings-
> drivers/net/phy/marvell.c:37: WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> drivers/net/phy/marvell.c:39: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

> Signed-off-by: Avinash Kumar <avi.kp.137@...il.com>
> ---
>   drivers/net/phy/marvell.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 2e91477..2e3c778e 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -34,9 +34,9 @@
>   #include <linux/marvell_phy.h>
>   #include <linux/of.h>
>
> -#include <asm/io.h>
> +#include <linux/io.h>
>   #include <asm/irq.h>
> -#include <asm/uaccess.h>
> +#include <linux/uaccess.h>

    You should move these #include's to the group of <linux/> #include's  now.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html