lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Oct 2013 10:29:50 -0700 From: Joe Perches <joe@...ches.com> To: "Kelleter," Günther <GKelleter@...us.com> Cc: "andrew.hendry@...il.com" <andrew.hendry@...il.com>, "davem@...emloft.net" <davem@...emloft.net>, "linux-x25@...r.kernel.org" <linux-x25@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] X.25: Fix address field length calculation On Tue, 2013-10-15 at 14:29 +0000, Kelleter, Günther wrote: > Addresses are BCD encoded, not ASCII. x25_addr_ntoa got it right. [] > Wrong length calculation leads to rejection of CALL ACCEPT packets. [] > diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c [] > @@ -98,7 +98,7 @@ int x25_parse_address_block(struct sk_buff *skb, > } > len = *skb->data; > - needed = 1 + (len >> 4) + (len & 0x0f); > + needed = 1 + ((len >> 4) + (len & 0x0f) + 1) / 2; This calculation looks odd. Perhaps use bcd.h instead? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists