netdev - Re: [PATCH v3 net-next] openvswitch: fix vport-netdev unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMEtUuyyR7sgGaDbQ0RmVfaY1uQr+wniv2DcsYUqCkG3uWgv5g@mail.gmail.com>
Date:	Tue, 15 Oct 2013 14:49:41 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Pravin B Shelar <pshelar@...ira.com>,
	Jiri Pirko <jiri@...nulli.us>, Cong Wang <amwang@...hat.com>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net-next] openvswitch: fix vport-netdev unregister

On Tue, Oct 15, 2013 at 9:53 AM, Alexei Starovoitov <ast@...mgrid.com> wrote:
> On Tue, Oct 15, 2013 at 8:31 AM, Jesse Gross <jesse@...ira.com> wrote:
>> On Sun, Oct 13, 2013 at 8:50 PM, Alexei Starovoitov <ast@...mgrid.com> wrote:
>>> diff --git a/net/openvswitch/dp_notify.c b/net/openvswitch/dp_notify.c
>>> index c323567..ffa429a 100644
>>> --- a/net/openvswitch/dp_notify.c
>>> +++ b/net/openvswitch/dp_notify.c
>>> @@ -59,15 +59,9 @@ void ovs_dp_notify_wq(struct work_struct *work)
>>>                         struct hlist_node *n;
>>>
>>>                         hlist_for_each_entry_safe(vport, n, &dp->ports[i], dp_hash_node) {
>>> -                               struct netdev_vport *netdev_vport;
>>> -
>>>                                 if (vport->ops->type != OVS_VPORT_TYPE_NETDEV)
>>>                                         continue;
>>> -
>>> -                               netdev_vport = netdev_vport_priv(vport);
>>> -                               if (netdev_vport->dev->reg_state == NETREG_UNREGISTERED ||
>>> -                                   netdev_vport->dev->reg_state == NETREG_UNREGISTERING)
>>> -                                       dp_detach_port_notify(vport);
>>> +                               dp_detach_port_notify(vport);
>>
>> Doesn't this free *all* ports of type OVS_VPORT_TYPE_NETDEV when any
>> one of them is removed?
>
> sorry. not sure what I was thinking on Sunday evening. will respin

will take it back. the check was removed to prevent hang upon dev netns moves,
since reg_state will still be == netreg_registered,
but yes, different check is needed.
sending v4
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html