netdev - [PATCH v4 net 2/3] sctp: Use software crc32 checksum when xfrm transform will happen.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1381888891-31186-3-git-send-email-vyasevich@gmail.com>
Date:	Tue, 15 Oct 2013 22:01:30 -0400
From:	Vlad Yasevich <vyasevich@...il.com>
To:	netdev@...r.kernel.org
Cc:	linux-sctp@...r.kernel.org, fan.du@...driver.com,
	Neil Horman <nhorman@...driver.com>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	Vlad Yasevich <vyasevich@...il.com>
Subject: [PATCH v4 net 2/3] sctp: Use software crc32 checksum when xfrm transform will happen.

From: Fan Du <fan.du@...driver.com>

igb/ixgbe have hardware sctp checksum support, when this feature is enabled
and also IPsec is armed to protect sctp traffic, ugly things happened as
xfrm_output checks CHECKSUM_PARTIAL to do checksum operation(sum every thing
up and pack the 16bits result in the checksum field). The result is fail
establishment of sctp communication.

Cc: Neil Horman <nhorman@...driver.com>
Cc: Steffen Klassert <steffen.klassert@...unet.com>
Signed-off-by: Fan Du <fan.du@...driver.com>
Signed-off-by: Vlad Yasevich <vyasevich@...il.com>
---
 net/sctp/output.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/sctp/output.c b/net/sctp/output.c
index 0ac3a65..d35b54c 100644
--- a/net/sctp/output.c
+++ b/net/sctp/output.c
@@ -536,7 +536,8 @@ int sctp_packet_transmit(struct sctp_packet *packet)
 	 * by CRC32-C as described in <draft-ietf-tsvwg-sctpcsum-02.txt>.
 	 */
 	if (!sctp_checksum_disable) {
-		if (!(dst->dev->features & NETIF_F_SCTP_CSUM)) {
+		if (!(dst->dev->features & NETIF_F_SCTP_CSUM) ||
+		    (dst_xfrm(dst) != NULL)) {
 			__u32 crc32 = sctp_start_cksum((__u8 *)sh, cksum_buf_len);
 
 			/* 3) Put the resultant value into the checksum field in the
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html