netdev - Re: [PATCH v2] Stmmac: fix a bug when clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131017.153915.2233536980001549266.davem@davemloft.net>
Date:	Thu, 17 Oct 2013 15:39:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mcuos.com@...il.com
Cc:	netdev@...r.kernel.org, peppe.cavallaro@...com
Subject: Re: [PATCH v2] Stmmac: fix a bug when clk_csr is euqal to 0x0

From: Wan ZongShun <mcuos.com@...il.com>
Date: Sat, 12 Oct 2013 10:04:20 +0800

> According to spec, if csr clock freq is 60-100Mhz, we have to set CR[5:2] = 0000
> but when I set the 'plat_dat.clk_csr = 0',acctually, this value is not used
> since the driver code judge 'if (!priv->plat->clk_csr)' then go to dynamic tune
> the MDC clock. So this patch is to add other judge condition.
> 
> Signed-off-by: Wan Zongshun <mcuos.com@...il.com>

There are still many problems with this patch.

Do not capitalize "Stmmac" in the subject prefix, use plain "stmmac: "

There is a typo in "equal" in the subject line.

> @@ -148,6 +149,8 @@ Where:
>         GMAC also enables the 4xPBL by default.
>     o fixed_burst/mixed_burst/burst_len
>   o clk_csr: fixed CSR Clock range selection.
> + o dynamic_mdc_clk_en: If it is set to >=1 MDC clk will be selected
> dynamically,
> +               or else you must set a fixed CSR Clock range to clk_src.
>   o has_gmac: uses the GMAC core.
>   o enh_desc: if sets the MAC will use the enhanced descriptor structure.
>   o tx_coe: core is able to perform the tx csum in HW.

The patch has been corrupted by your email client.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html