netdev - Re: [PATCH v2 net-next] net: refactor sk_page_frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131017.154625.1687353288700164892.davem@davemloft.net>
Date:	Thu, 17 Oct 2013 15:46:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	mwdalton@...gle.com, dborkman@...hat.com, netdev@...r.kernel.org,
	ffusco@...hat.com, ycheng@...gle.com, ncardwell@...gle.com,
	digitaleric@...gle.com
Subject: Re: [PATCH v2 net-next] net: refactor sk_page_frag_refill()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 12 Oct 2013 21:46:31 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> While working on virtio_net new allocation strategy to increase
> payload/truesize ratio, we found that refactoring sk_page_frag_refill()
> was needed.
> 
> This patch splits sk_page_frag_refill() into two parts, adding
> page_frag_refill() which can be used without a socket.
> 
> While we are at it, add a minimum frag size of 32 for
> sk_page_frag_refill()
> 
> Michael will either use netdev_alloc_frag() from softirq context,
> or page_frag_refill() from process context in refill_work() (GFP_KERNEL
> allocations)
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Please rename this to something like "skb_page_frag_refill" so that it
is clear that this is a networking interface.

Thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html