netdev - Re: [net-next REPOST] 8390 ei_debug : Reenable the use of debugging in 8390 based chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131017.155953.174894765079484399.davem@davemloft.net>
Date:	Thu, 17 Oct 2013 15:59:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tedheadster@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next REPOST] 8390 ei_debug : Reenable the use of
 debugging in 8390 based chips

From: Matthew Whitehead <tedheadster@...il.com>
Date: Mon, 14 Oct 2013 22:46:01 -0400

> Ethernet boards based on the 8390 chip had an '#ifdef notdef' disabling the
> use of the debug variable ei_debug. Reenable it for those of us who still
> occasionally use it.
> 
> Also handle the case of the 'ne' driver which uses 8390p.o rather than
> 8390.o. In that case ei_debug is aliased to eip_debug so it doesn't clash
> with the previously exported ei_debug.
> 
> Signed-off-by: Matthew Whitehead <tedheadster@...il.com>

I'd rather not encourage the use of things like this.

We have a standard, run time, way to enable and disable debugging
output on a per-netdevice basis.  And the "default" value of which can
be controlled by a module parameter if need be.

Please convert the driver to this method instead.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html