netdev - Re: [PATCH net] tcp: fix incorrect ca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB_+Fg5k5qKG=1T30=+BXZaWGoLsREGMg2ZuEJwky_OBm_AJ5w@mail.gmail.com>
Date:	Fri, 18 Oct 2013 10:29:00 -0700
From:	Nandita Dukkipati <nanditad@...gle.com>
To:	Neal Cardwell <ncardwell@...gle.com>
Cc:	Yuchung Cheng <ycheng@...gle.com>,
	David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>, michael@...rretts.net,
	jwboyer@...oraproject.org,
	"Steinar H. Gunderson" <sesse@...gle.com>,
	dormando <dormando@...ia.net>
Subject: Re: [PATCH net] tcp: fix incorrect ca_state in tail loss probe

On Sun, Oct 13, 2013 at 10:55 PM, Neal Cardwell <ncardwell@...gle.com> wrote:
>
> On Sat, Oct 12, 2013 at 1:16 PM, Yuchung Cheng <ycheng@...gle.com> wrote:
> > On receiving an ACK that covers the loss probe sequence, TLP
> > immediately sets the congestion state to Open, even though some packets
> > are not recovered and retransmisssion are on the way.  The later ACks
> > may trigger a WARN_ON check in step D of tcp_fastretrans_alert(), e.g.,
> > https://bugzilla.redhat.com/show_bug.cgi?id=989251
> >
> > The fix is to follow the similar procedure in recovery by calling
> > tcp_try_keep_open(). The sender switches to Open state if no packets
> > are retransmissted. Otherwise it goes to Disorder and let subsequent
> > ACKs move the state to Recovery or Open.
> >
> > Reported-By: Michael Sterrett <michael@...rretts.net>
> > Tested-By: Dormando <dormando@...ia.net>
> > Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
>
> Acked-by: Neal Cardwell <ncardwell@...gle.com>

Acked-by: Nandita Dukkipati <nanditad@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html