netdev - Re: [PATCH] packet: Deliver VLAN TPID to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131018105655.2cdc628e@nehalam.linuxnetplumber.net>
Date:	Fri, 18 Oct 2013 10:56:55 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Atzm Watanabe <atzm@...atosphere.co.jp>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] packet: Deliver VLAN TPID to userspace

On Sat, 19 Oct 2013 02:08:11 +0900
Atzm Watanabe <atzm@...atosphere.co.jp> wrote:

> diff --git a/include/uapi/linux/if_packet.h b/include/uapi/linux/if_packet.h
> index dbf0666..6e36e0a 100644
> --- a/include/uapi/linux/if_packet.h
> +++ b/include/uapi/linux/if_packet.h
> @@ -83,7 +83,7 @@ struct tpacket_auxdata {
>  	__u16		tp_mac;
>  	__u16		tp_net;
>  	__u16		tp_vlan_tci;
> -	__u16		tp_padding;
> +	__u16		tp_vlan_tpid;
>  };
>  
>  /* Rx ring - header status */
> @@ -132,12 +132,13 @@ struct tpacket2_hdr {
>  	__u32		tp_sec;
>  	__u32		tp_nsec;
>  	__u16		tp_vlan_tci;
> -	__u16		tp_padding;
> +	__u16		tp_vlan_tpid;
>  };
>  
>  struct tpacket_hdr_variant1 {
>  	__u32	tp_rxhash;
>  	__u32	tp_vlan_tci;
> +	__u32	tp_vlan_tpid;
>  };

The last change will break ABI to userspace applications.
You can reuse padding elements; but you can't increase (or shrink)
an existing structure.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html