netdev - Re: [patch net REPOST 3/3] ip_output: do skb ufo init for peeked non ufo skb as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Oct 2013 22:45:42 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
CC:	davem@...emloft.net, eric.dumazet@...il.com,
	hannes@...essinduktion.or, jdmason@...zu.us,
	yoshfuji@...ux-ipv6.org, kuznet@....inr.ac.ru, jmorris@...ei.org,
	kaber@...sh.net, herbert@...dor.apana.org.au
Subject: Re: [patch net REPOST 3/3] ip_output: do skb ufo init for peeked
 non ufo skb as well

On 10/18/2013 09:13 PM, Jiri Pirko wrote:

> Now, if user application does:
> sendto len<mtu flag MSG_MORE
> sendto len>mtu flag 0
> The skb is not treated as fragmented one because it is not initialized
> that way. So move the initialization to fix this.

> introduced by:
> commit e89e9cf539a28df7d0eb1d0a545368e9920b34ac "[IPv4/IPv6]: UFO Scatter-gather approach"

> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
> ---
>   net/ipv4/ip_output.c | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)

> diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> index a04d872..bd21c5d 100644
> --- a/net/ipv4/ip_output.c
> +++ b/net/ipv4/ip_output.c
> @@ -772,15 +772,19 @@ static inline int ip_ufo_append_data(struct sock *sk,
>   		/* initialize protocol header pointer */
>   		skb->transport_header = skb->network_header + fragheaderlen;
>
> -		skb->ip_summed = CHECKSUM_PARTIAL;
>   		skb->csum = 0;
>
> -		/* specify the length of each IP datagram fragment */
> -		skb_shinfo(skb)->gso_size = maxfraglen - fragheaderlen;
> -		skb_shinfo(skb)->gso_type = SKB_GSO_UDP;
> +
>   		__skb_queue_tail(queue, skb);
> -	}
> +	} else if (skb_is_gso(skb))
> +		goto append;

    Same comment on the necessity of {} here.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html