netdev - Re: [PATCH 1/1] net: fix cipso packet validation when !NETLABEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1970192.CQWcaac4RA@sifl>
Date:	Thu, 17 Oct 2013 21:20:45 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	seif@...vell.com
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	thomas.petazzoni@...e-electrons.com, dima@...vell.com
Subject: Re: [PATCH 1/1] net: fix cipso packet validation when !NETLABEL

On Thursday, October 17, 2013 03:47:42 PM David Miller wrote:
> From: Paul Moore <paul@...l-moore.com>
> Date: Mon, 14 Oct 2013 11:12:47 -0400
> 
> > On Saturday, October 12, 2013 10:21:50 PM Seif Mazareeb wrote:
> >> When CONFIG_NETLABEL is disabled, the cipso_v4_validate() function could
> >> loop forever in the main loop if opt[opt_iter +1] == 0, this will causing
> >> a
> >> kernel crash in an SMP system, since the CPU executing this function will
> >> stall /not respond to IPIs.
> >> 
> >> This problem can be reproduced by running the IP Stack Integrity Checker
> >> (http://isic.sourceforge.net) using the following command on a Linux
> >> machine connected to DUT:
> >> 
> >> "icmpsic -s rand -d <DUT IP address> -r 123456"
> >> wait (1-2 min)
> >> 
> >> Signed-off-by: Seif Mazareeb <seif@...vell.com>
> > 
> > Thanks for sticking with this.
> > 
> > Acked-by: Paul Moore <paul@...l-moore.com>
> 
> This patch, like all the others Seif submitted, has been corrupted by
> his email client and is this unusable.

Seif, please fix this.  If I don't see a new patch by tomorrow I'll go ahead 
and resubmit.

-- 
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html