| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131020023418.GA6737@localhost>
Date: Sun, 20 Oct 2013 10:34:18 +0800
From: Fengguang Wu <fengguang.wu@...el.com>
To: Jason Wang <jasowang@...hat.com>
Cc: virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [virtio-net] BUG: sleeping function called from invalid context at
kernel/mutex.c:616
Greetings,
I got the below dmesg and the first bad commit is
commit 3ab098df35f8b98b6553edc2e40234af512ba877
Author: Jason Wang <jasowang@...hat.com>
Date: Tue Oct 15 11:18:58 2013 +0800
virtio-net: don't respond to cpu hotplug notifier if we're not ready
We're trying to re-configure the affinity unconditionally in cpu hotplug
callback. This may lead the issue during resuming from s3/s4 since
- virt queues haven't been allocated at that time.
- it's unnecessary since thaw method will re-configure the affinity.
Fix this issue by checking the config_enable and do nothing is we're not ready.
The bug were introduced by commit 8de4b2f3ae90c8fc0f17eeaab87d5a951b66ee17
(virtio-net: reset virtqueue affinity when doing cpu hotplug).
Cc: Rusty Russell <rusty@...tcorp.com.au>
Cc: Michael S. Tsirkin <mst@...hat.com>
Cc: Wanlong Gao <gaowanlong@...fujitsu.com>
Acked-by: Michael S. Tsirkin <mst@...hat.com>
Reviewed-by: Wanlong Gao <gaowanlong@...fujitsu.com>
Signed-off-by: Jason Wang <jasowang@...hat.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
[ 622.944441] CPU0 attaching NULL sched-domain.
[ 622.944446] CPU1 attaching NULL sched-domain.
[ 622.944485] CPU0 attaching NULL sched-domain.
[ 622.950795] BUG: sleeping function called from invalid context at kernel/mutex.c:616
[ 622.950796] in_atomic(): 1, irqs_disabled(): 1, pid: 10, name: migration/1
[ 622.950796] no locks held by migration/1/10.
[ 622.950798] CPU: 1 PID: 10 Comm: migration/1 Not tainted 3.12.0-rc5-wl-01249-gb91e82d #317
[ 622.950799] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[ 622.950802] 0000000000000000 ffff88001d42dba0 ffffffff81a32f22 ffff88001bfb9c70
[ 622.950803] ffff88001d42dbb0 ffffffff810edb02 ffff88001d42dc38 ffffffff81a396ed
[ 622.950805] 0000000000000046 ffff88001d42dbe8 ffffffff810e861d 0000000000000000
[ 622.950805] Call Trace:
[ 622.950810] [<ffffffff81a32f22>] dump_stack+0x54/0x74
[ 622.950815] [<ffffffff810edb02>] __might_sleep+0x112/0x114
[ 622.950817] [<ffffffff81a396ed>] mutex_lock_nested+0x3c/0x3c6
[ 622.950818] [<ffffffff810e861d>] ? up+0x39/0x3e
[ 622.950821] [<ffffffff8153ea7c>] ? acpi_os_signal_semaphore+0x21/0x2d
[ 622.950824] [<ffffffff81565ed1>] ? acpi_ut_release_mutex+0x5e/0x62
[ 622.950828] [<ffffffff816d04ec>] virtnet_cpu_callback+0x33/0x87
[ 622.950830] [<ffffffff81a42576>] notifier_call_chain+0x3c/0x5e
[ 622.950832] [<ffffffff810e86a8>] __raw_notifier_call_chain+0xe/0x10
[ 622.950835] [<ffffffff810c5556>] __cpu_notify+0x20/0x37
[ 622.950836] [<ffffffff810c5580>] cpu_notify+0x13/0x15
[ 622.950838] [<ffffffff81a237cd>] take_cpu_down+0x27/0x3a
[ 622.950841] [<ffffffff81136289>] stop_machine_cpu_stop+0x93/0xf1
[ 622.950842] [<ffffffff81136167>] cpu_stopper_thread+0xa0/0x12f
[ 622.950844] [<ffffffff811361f6>] ? cpu_stopper_thread+0x12f/0x12f
[ 622.950847] [<ffffffff81119710>] ? lock_release_holdtime.part.7+0xa3/0xa8
[ 622.950848] [<ffffffff81135e4b>] ? cpu_stop_should_run+0x3f/0x47
[ 622.950850] [<ffffffff810ea9b0>] smpboot_thread_fn+0x1c5/0x1e3
[ 622.950852] [<ffffffff810ea7eb>] ? lg_global_unlock+0x67/0x67
[ 622.950854] [<ffffffff810e36b7>] kthread+0xd8/0xe0
[ 622.950857] [<ffffffff81a3bfad>] ? wait_for_common+0x12f/0x164
[ 622.950859] [<ffffffff810e35df>] ? kthread_create_on_node+0x124/0x124
[ 622.950861] [<ffffffff81a45ffc>] ret_from_fork+0x7c/0xb0
[ 622.950862] [<ffffffff810e35df>] ? kthread_create_on_node+0x124/0x124
[ 622.950876] smpboot: CPU 1 is now offline
[ 623.194556] SMP alternatives: lockdep: fixing up alternatives
[ 623.194559] smpboot: Booting Node 0 Processor 1 APIC 0x1
git bisect start b91e82dc6ad55f2d39b92e731c6bb95cc44a923c 61e6cfa80de5760bbe406f4e815b7739205754d2 --
git bisect good a1b13b9ad3759dca24c6b721ee026c540a4e6564 # 21:47 20+ 2 rt2x00: rt2800pci: use module_pci_driver macro
git bisect good fd1b6d51e114be121460a07e9ccb2005928d0c88 # 22:38 20+ 0 Merge branch 'pm-cpufreq-next' into linux-next
git bisect good 11ec23f2c0874676a3321d304d2a03e2c46dc680 # 23:13 20+ 4 Merge 'shawnguo/for-next' into devel-inn-x86_64-201310190634
git bisect good e358784297992b012e8071764d996191dd2b1a54 # 00:19 20+ 1 can: flexcan: fix mx28 detection by rearanging OF match table
git bisect bad 2b13d06c9584b4eb773f1e80bbaedab9a1c344e1 # 00:35 0- 6 wanxl: fix info leak in ioctl
git bisect good 725907827a7f46dfb5df6e4f3d8f9bcbc9903877 # 01:29 20+ 2 Merge branch 'sctp_csum'
git bisect bad ce97fef4235378108ed3bd96e1b3eab8fd0a1fbd # 01:54 0- 17 net: qmi_wwan: Olivetti Olicard 200 support
git bisect good dbbd2ad89bb1f86b94b23bb2e56d4935717f9b94 # 02:44 20+ 1 net/ethernet: cpsw: Bugfix interrupts before enabling napi
git bisect good 39bb93f88c5db54cbe1df0b0aa957b3a8f2227ed # 03:11 20+ 3 yam: remove a no-op in yam_ioctl()
git bisect bad 35ed159bfd96a7547ec277ed8b550c7cbd9841b6 # 03:22 0- 1 virtio-net: refill only when device is up during setting queues
git bisect bad 3ab098df35f8b98b6553edc2e40234af512ba877 # 03:39 0- 9 virtio-net: don't respond to cpu hotplug notifier if we're not ready
git bisect good 39bb93f88c5db54cbe1df0b0aa957b3a8f2227ed # 04:52 60+ 7 yam: remove a no-op in yam_ioctl()
git bisect bad b91e82dc6ad55f2d39b92e731c6bb95cc44a923c # 04:53 0- 18 Merge 'lunn/v3.12-rc5-rafael-next-dove-cpufreq' into devel-inn-x86_64-201310190634
git bisect good bc823919e42bc7a31ee06fa040194db6f455c2e3 # 06:04 60+ 8 Revert "virtio-net: don't respond to cpu hotplug notifier if we're not ready"
git bisect good 31d141e3a666269a3b6fcccddb0351caf7454240 # 07:11 60+ 12 Linux 3.12-rc6
git bisect good a0cf1abc25ac197dd97b857c0f6341066a8cb1cf # 08:10 60+ 10 Add linux-next specific files for 20130927
Thanks,
Fengguang
View attachment "dmesg-nfsroot-waimea-6:20131019151041:x86_64-lkp-CONFIG_SCSI_DEBUG:3.12.0-rc5-wl-01249-gb91e82d:317" of type "text/plain" (51265 bytes)
Download attachment "bisect-b91e82dc6ad55f2d39b92e731c6bb95cc44a923c-x86_64-lkp-CONFIG_SCSI_DEBUG-BUG:-sleeping-function-called-from-invalid-context-at-kernel-mutex-c-126797.log" of type "application/octet-stream" (34532 bytes)
View attachment "config-3.12.0-rc5-wl-01249-gb91e82d" of type "text/plain" (80194 bytes)
Powered by blists - more mailing lists