lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Oct 2013 21:14:11 +0200 From: Tino Reichardt <list-linux-netdev@...ilk.de> To: netdev@...r.kernel.org Subject: Re: [PATCH net-next v2 01/07] 8139too: Support for byte queue limits * Joe Perches <joe@...ches.com> wrote: > On Sun, 2013-10-20 at 20:13 +0200, Tino Reichardt wrote: > > Changes to 8139too driver to use byte queue limits. > [] > > diff --git a/drivers/net/ethernet/realtek/8139too.c b/drivers/net/ethernet/realtek/8139too.c > [] > > @@ -1409,6 +1413,8 @@ static void rtl8139_hw_start (struct net_device *dev) > [] > > netdev_dbg(dev, "init buffer addresses\n"); > > + if (likely(bql_disable == false)) > > + netdev_reset_queue(dev); > > Much prefer: > > if (unlikely(bql_disable)) Okay, i will resend an updated v3 patchset. -- Best regards, TR -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists